Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solver updates #223

Merged
merged 16 commits into from
Aug 26, 2024
Merged

solver updates #223

merged 16 commits into from
Aug 26, 2024

Conversation

julesghub
Copy link
Member

Some solver updates to clean up things

  • problem_description removed.
  • access to unknowns only via the Unknowns class.
  • making the abstract SolverBaseClass report errors if it's used directly.

@julesghub julesghub requested a review from lmoresi August 9, 2024 09:00
@julesghub julesghub changed the title solver update solver updates Aug 9, 2024
@julesghub
Copy link
Member Author

Better attribute naming ideas:

  • _total_instances -> uw_object_count
  • uw_id rather than instance

Also starting a runtime record class, currently in __init__.py
uw_record gives information on the installation and runtime

Access via:
import underworld3 as uw
uw.uw_record.get_installation_data
uw.uw_record.get_runtime_data

* uw_record lives in underworld/utilities/__init__.py
* uw_record collects data only on proc 0 and broadcasts to all procs.
  For get_runtime_data be aware of this design. As calling often could cause
  an operational overhead. While get_installation_data only bcasts at initialisation.
* Coming idea is to serialised the output get_installation_data into
  hdf5 files
* access via underworld3.auditor
* test included in test_0005_utils.py
@julesghub julesghub force-pushed the julesghub/generic-solver-update branch from 061eb97 to 0f4e007 Compare August 21, 2024 03:47
@julesghub
Copy link
Member Author

@lmoresi - this change should be good to go. But happy to discuss the instance number issue first when you have time.
Let me know.

@julesghub julesghub merged commit 790307d into development Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant